Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(VideoPlayer): Vidstack POC #3002

Closed
wants to merge 9 commits into from
Closed

feat(VideoPlayer): Vidstack POC #3002

wants to merge 9 commits into from

Conversation

smithgajjar09
Copy link
Contributor

@smithgajjar09 smithgajjar09 commented Jan 5, 2025 •
edited
Loading

@smithgajjar09 smithgajjar09 requested a review from a team as a code owner January 5, 2025 12:33
@smithgajjar09 smithgajjar09 marked this pull request as draft January 5, 2025 12:34
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit bfcc056.

☁️ Nx Cloud last updated this comment at 2025-01-07 16:11:27 UTC

@smithgajjar09 smithgajjar09 changed the title Vidstack VideoPlayer POC feat(VideoPlayer): Vidstack POC Jan 7, 2025
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

codecademydev commented Jan 7, 2025 •
edited by smithgajjar09
Loading

🚀 Styleguide deploy preview ready!

https://677d5059d27b803a39b6e43f--gamut-preview.netlify.app/?path=/docs/molecules-videoplayer--docs

Deploy Logs

dreamwasp
dreamwasp reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few styling tweaks that would need to be made, but after checking out your implementation and reviewing the docs i'm confident vidstack would work and integrate well wioth gamut 🔥

@smithgajjar09 smithgajjar09 mentioned this pull request Jan 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp left review comments

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smithgajjar09 @codecademydev @dreamwasp